Add e2e tests for grpc #4212
Merged
Add e2e tests for grpc #4212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
ElvinEfendi
reviewed
Jun 21, 2019
| {{ if not (empty $location.UpstreamVhost) }} | ||
| {{ $proxySetHeader }} Host "{{ $location.UpstreamVhost }}"; | ||
| {{ else }} | ||
| {{ $proxySetHeader }} Host $best_http_host; | ||
| {{ end }} | ||
| {{ end }} |
There was a problem hiding this comment.
Is this the actual bug fix? Can you elaborate how?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
facebook-github-bot
pushed a commit
to magma/magma
that referenced
this pull request
May 28, 2020
Summary: - Proxied syncRPC requests had Host header set to the orc8r-controller FQDN so we weren't able to parse a service name out of it - Set the Host header explicitly with grpc_set_header directive - Seems like this should work according to kubernetes/ingress-nginx#4212 Reviewed By: uri200 Differential Revision: D21758666 fbshipit-source-id: b00a884012e36452e1108bf8d9f232b1da8b374e
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fixes #3706
Special notes for your reviewer: