-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPT: Add variable to define custom sampler host and port #4105
Conversation
Welcome @reynaldiwijaya! |
Hi @reynaldiwijaya. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
@reynaldiwijaya please update the configmap configuration. If you do that this LGTM |
Codecov Report
@@ Coverage Diff @@
## master #4105 +/- ##
========================================
Coverage ? 57.7%
========================================
Files ? 87
Lines ? 6452
Branches ? 0
========================================
Hits ? 3723
Misses ? 2298
Partials ? 431
Continue to review full report at Codecov.
|
@aledbf I only found documentation for anything related to configmap (docs/user-guide/nginx-configuration/configmap.md). If this is the file that you meant, I have updated it. If it is not the one, please let me know, i will update accordingly |
/lgtm |
@reynaldiwijaya thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, reynaldiwijaya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR will accommodate custom Jaeger Sampler Remote Host and Remote Port. In many cases we want a centralize sampler configuration (in collector). The current implementation of nginx ingress will only use localhost jaeger agent for this purpose. The url given does not include
/sampling
as well, which is not going to work if it is not includedWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes #3894
Special notes for your reviewer:
Some documentation in pull request is not updated, e.g.
make verify
is no longer exist in Makefile