-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ListIngresses to add filters #4102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4102 +/- ##
==========================================
- Coverage 57.7% 57.65% -0.05%
==========================================
Files 87 87
Lines 6452 6452
==========================================
- Hits 3723 3720 -3
- Misses 2298 2300 +2
- Partials 431 432 +1
Continue to review full report at Codecov.
|
/retest |
|
The inefficient code in the validation webhook. You can see the issue after ~50 ingresses
Fixed |
Hmm interesting. The only inefficiency I see in the code is that it was doing an extra loop over the ingresses, but would not have expected this to be that noticeable for 50 iterations where every iteration is basically comparing some string. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: