Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ListIngresses to add filters #4102

Merged
merged 1 commit into from
May 22, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented May 18, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and ElvinEfendi May 18, 2019 10:09
@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #4102 into master will decrease coverage by 0.04%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4102      +/-   ##
==========================================
- Coverage    57.7%   57.65%   -0.05%     
==========================================
  Files          87       87              
  Lines        6452     6452              
==========================================
- Hits         3723     3720       -3     
- Misses       2298     2300       +2     
- Partials      431      432       +1
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 29% <ø> (ø) ⬆️
internal/ingress/status/status.go 73.18% <100%> (ø) ⬆️
internal/ingress/controller/store/store.go 61.75% <33.33%> (-0.3%) ⬇️
internal/ingress/controller/controller.go 46.56% <55.55%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update def96a5...bae49a4. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented May 22, 2019

/retest

@ElvinEfendi
Copy link
Member

  1. What's the motivation?
  2. Are the vendor changes related? They don't seem to be.

@aledbf
Copy link
Member Author

aledbf commented May 22, 2019

What's the motivation?

The inefficient code in the validation webhook. You can see the issue after ~50 ingresses

Are the vendor changes related? They don't seem to be.

Fixed

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2019
@ElvinEfendi
Copy link
Member

The inefficient code in the validation webhook. You can see the issue after ~50 ingresses

Hmm interesting. The only inefficiency I see in the code is that it was doing an extra loop over the ingresses, but would not have expected this to be that noticeable for 50 iterations where every iteration is basically comparing some string.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3e3e29b into kubernetes:master May 22, 2019
@aledbf aledbf deleted the listingresses branch May 22, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants