Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs have incorrect command in baremetal.md #4036

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Docs have incorrect command in baremetal.md #4036

merged 1 commit into from
Apr 26, 2019

Conversation

Yantrio
Copy link
Contributor

@Yantrio Yantrio commented Apr 25, 2019

What this PR does / why we need it:
The output shown is for kubectl get node and not kubectl describe node. this is incorrect and can confuse people

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
I've updated the docs to use the correct command.

Special notes for your reviewer:

The output shown is for `kubectl get node` and not `kubectl describe node`.

I've updated the docs to use the correct command.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 25, 2019
@aledbf
Copy link
Member

aledbf commented Apr 25, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@aledbf
Copy link
Member

aledbf commented Apr 25, 2019

@Yantrio thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Yantrio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit ddedd16 into kubernetes:master Apr 26, 2019
@Yantrio Yantrio deleted the patch-1 branch April 30, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants