Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing basic usage documentation link #3847

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

tjamet
Copy link
Contributor

@tjamet tjamet commented Mar 4, 2019

What this PR does / why we need it:

Working on #3802 I found out that make live-docs was reporting

INFO    -  The following pages exist in the docs directory, but are not
included in the "nav" configuration:
  - user-guide/basic-usage.md

making this documentation page unavailable from the public documentation.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

fix `make live-docs` reporting

```
INFO    -  The following pages exist in the docs directory, but are not
included in the "nav" configuration:
  - user-guide/basic-usage.md
```

Change-Id: Iafd4d49b063ffb676cc303135495283a125b5297
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2019
@aledbf
Copy link
Member

aledbf commented Mar 4, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2019
@aledbf
Copy link
Member

aledbf commented Mar 4, 2019

@tjamet thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, tjamet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7a0ca9c into kubernetes:master Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants