-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade openresty/lua-resty-balancer #3809
Upgrade openresty/lua-resty-balancer #3809
Conversation
@ArchangelSDY please increase the version to 0.79 in |
This fixes bug in chash:reinit which prevents endpoints from being updated correctly. See openresty/lua-resty-balancer#25
c4abd95
to
db4d012
Compare
@aledbf updated. |
/lgtm |
@ArchangelSDY thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ArchangelSDY The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I will update the ingress controller image after this PR is merged and the new image is available in quay.io |
Cool, thanks @aledbf ! |
@ArchangelSDY first thanks for fixing this! Did you see any impact of this on ingress-nginx? I looked into this and only impact I could see is that ingress-nginx would unnecessarily keep calling
true . But no impact on load balancing logic.
|
@ElvinEfendi Here is the case we encountered:
|
@ArchangelSDY I see, that makes sense. I think this is also the root cause of some session affinity related issues where users were complaining that load balancing is not working. |
What this PR does / why we need it:
This fixes bug in chash:reinit which prevents endpoints from being updated correctly.
See openresty/lua-resty-balancer#25
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: