Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old unused lua dicts #3734

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from aledbf and bowei February 6, 2019 22:33
@aledbf
Copy link
Member

aledbf commented Feb 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ElvinEfendi
Copy link
Member Author

ElvinEfendi commented Feb 6, 2019

flaky test that's being tackled at #3728

E0206 23:43:53.636640    8618 store.go:688] error reading secret reference in annotation "auth-secret": unexpected key format: "ns/name/garbage"
--- FAIL: TestListIngresses (0.00s)
    store_test.go:1041: Expected Ingress test-2 but got test-3
    store_test.go:1045: Expected Ingress test-3 but got test-2

@k8s-ci-robot k8s-ci-robot merged commit 4dd0365 into kubernetes:master Feb 7, 2019
@ElvinEfendi ElvinEfendi deleted the remove-old-dicts branch February 7, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants