add limit connection status code #3640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
aledbf
reviewed
Jan 9, 2019
| // LimitConnStatusCode Sets the status code to return in response to rejected connections. | ||
| // http://nginx.org/en/docs/http/ngx_http_limit_conn_module.html#limit_conn_status | ||
| // Default: 503 | ||
| LimitConnStatusCode int `json:"limit-conn-status-code"` |
There was a problem hiding this comment.
|
@shaikatz please squash the commits and we are ok to merge |
shaikatz
force-pushed
the
limit-con-status-code
branch
from
e555974
to
becd919
Compare
add default conn status code add missing colon add limit connection status code
shaikatz
force-pushed
the
limit-con-status-code
branch
from
becd919
to
edd87fb
Compare
|
@aledbf |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, shaikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@shaikatz thanks! |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When settings
nginx.ingress.kubernetes.io/limit-connections: 'X'there is currently no way to change the status code for requests that reached the connection limit.