Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle_error_when_executing_diff #3553

Merged

Conversation

zhuguihua
Copy link

Executing diff can return exit code != 0, we should handle this error.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2018
@aledbf
Copy link
Member

aledbf commented Dec 12, 2018

@zhuguihua not sure we should return an error because of the diff exit code. This is just informational, not something affects the ingress controller. Returning an error means we will retry the build of the model

@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2018
@zhuguihua zhuguihua force-pushed the handle_error_when_executing_diff branch from 99353ca to d22146f Compare December 12, 2018 05:53
@zhuguihua
Copy link
Author

@aledbf Thanks for your review, I did agree with you. The codes in this block are just only to show the nginx configuration differences. So I think errors of TempFile and WriteFile could not also be returned. I updated this patch, just give warning about differ command.

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2018
@aledbf
Copy link
Member

aledbf commented Dec 12, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2018
@aledbf
Copy link
Member

aledbf commented Dec 12, 2018

@zhuguihua thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, zhuguihua

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 02e6424 into kubernetes:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants