-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use opentracing_grpc_propagate_context when necessary #3470
Use opentracing_grpc_propagate_context when necessary #3470
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, still needs some unit tests here https://github.com/kubernetes/ingress-nginx/blob/master/internal/ingress/controller/template/template_test.go
78cdc1d
to
05bcd97
Compare
@diazjf Unit test added |
@andremarianiello please run |
05bcd97
to
467ce60
Compare
@aledbf Sorry, new dev machine, didn't set up autoformat. Pushed the formatting fixes. |
467ce60
to
9bb3c98
Compare
CI is still failing, like its using the code before my fixes, but I don't know why that is happening. Still investigating. |
I was using gofmt in Go 1.10, not 1.11. Fixing now |
4c13d1b
to
b80b199
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, andremarianiello The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@andremarianiello thanks! |
@aledbf Thank you! Is there a planned release date for 0.22.0? |
@andremarianiello we release every three or four weeks |
What this PR does / why we need it:
Opentracing header propagation via gRPC
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #fixes #3440
Special notes for your reviewer:
Second half of #3465