Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use opentracing_grpc_propagate_context when necessary #3470

Merged
merged 1 commit into from
Dec 1, 2018

Conversation

andremarianiello
Copy link
Contributor

What this PR does / why we need it:
Opentracing header propagation via gRPC

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

fixes #3440

Special notes for your reviewer:
Second half of #3465

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 27, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2018
Copy link

@diazjf diazjf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2018
@andremarianiello
Copy link
Contributor Author

@diazjf Unit test added

@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2018
@aledbf
Copy link
Member

aledbf commented Dec 1, 2018

@andremarianiello please run ./hack/verify-gofmt.sh to see the format error

@andremarianiello
Copy link
Contributor Author

@aledbf Sorry, new dev machine, didn't set up autoformat. Pushed the formatting fixes.

@andremarianiello
Copy link
Contributor Author

CI is still failing, like its using the code before my fixes, but I don't know why that is happening. Still investigating.

@andremarianiello
Copy link
Contributor Author

I was using gofmt in Go 1.10, not 1.11. Fixing now

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2018
@aledbf
Copy link
Member

aledbf commented Dec 1, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, andremarianiello

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2018
@aledbf
Copy link
Member

aledbf commented Dec 1, 2018

@andremarianiello thanks!

@k8s-ci-robot k8s-ci-robot merged commit 3112e12 into kubernetes:master Dec 1, 2018
@andremarianiello
Copy link
Contributor Author

@aledbf Thank you! Is there a planned release date for 0.22.0?

@andremarianiello andremarianiello deleted the grpc-opentracing branch December 1, 2018 23:05
@aledbf
Copy link
Member

aledbf commented Dec 1, 2018

@andremarianiello we release every three or four weeks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opentracing with gRPC
4 participants