Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Prometheus metrics in glbc controller #346

Merged
merged 1 commit into from
Feb 25, 2017
Merged

Expose Prometheus metrics in glbc controller #346

merged 1 commit into from
Feb 25, 2017

Conversation

piosz
Copy link
Member

@piosz piosz commented Feb 25, 2017

Some metrics are already collected but not exposed.

ref kubernetes/kubernetes#40736

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 25, 2017
@piosz piosz mentioned this pull request Feb 25, 2017
Closed
15 tasks
@k8s-reviewable
Copy link

This change is Reviewable

@piosz
Copy link
Member Author

piosz commented Feb 25, 2017

ref #238

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.099% when pulling fd7990d on piosz:metrics into 8f23451 on kubernetes:master.

@piosz
Copy link
Member Author

piosz commented Feb 25, 2017 •
edited
Loading

@aledbf this is a very simple change. Maybe you can take a look?

@aledbf aledbf assigned aledbf and unassigned bprashanth Feb 25, 2017
@aledbf
Copy link
Member

aledbf commented Feb 25, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2017
@aledbf aledbf merged commit 77395e0 into kubernetes:master Feb 25, 2017
@piosz
Copy link
Member Author

piosz commented Feb 25, 2017

@aledbf thanks!

@piosz piosz deleted the metrics branch February 25, 2017 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piosz @k8s-reviewable @coveralls @aledbf @bprashanth @k8s-ci-robot