Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #3366

Merged
merged 1 commit into from
Nov 5, 2018
Merged

Fix some typos #3366

merged 1 commit into from
Nov 5, 2018

Conversation

mooncak
Copy link
Contributor

@mooncak mooncak commented Nov 5, 2018

Signed-off-by: mooncake [email protected]

What this PR does / why we need it:
Fix some typos in below files:

  1. internal/ingress/controller/process/nginx.go
  2. internal/ingress/metric/collectors/controller.go
  3. internal/ingress/metric/collectors/socket.go
  4. internal/ingress/metric/collectors/testutils.go

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Signed-off-by: mooncake <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2018
@aledbf
Copy link
Member

aledbf commented Nov 5, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2018
@aledbf
Copy link
Member

aledbf commented Nov 5, 2018

@mooncak thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, mooncak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2018
@mooncak
Copy link
Contributor Author

mooncak commented Nov 5, 2018

/retest

@k8s-ci-robot k8s-ci-robot merged commit b4c5af1 into kubernetes:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants