Remove e2e boilerplate #3322
Merged
Remove e2e boilerplate #3322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
aledbf
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
size/XXL
aledbf
force-pushed
the
tests-cleanup
branch
2 times, most recently
from
4509340
to
646cee7
Compare
aledbf
removed
the
do-not-merge/work-in-progress
|
/lgtm muuch better! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@aledbf could you please explain what makes the error assertions unnecessary? |
Is not about the assertion itself but the lack of context using just Also, please check kubernetes/kubernetes#34059 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR starts the process to remove
Expect(err).ToNot(HaveOccurred())from the test and also avoid using methods from the framework package that return an error requiring an assert after the invocation.