-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nginx image #3219
Update nginx image #3219
Conversation
@@ -236,6 +236,18 @@ else | |||
fi | |||
|
|||
# Installing luarocks packages | |||
if [[ ${ARCH} == "armv7l" ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these exports are required to install lrexlib-pcre
in different platforms
@@ -69,7 +69,6 @@ docker run \ | |||
--rm \ | |||
${DOCKER_OPTS} \ | |||
-v ${HOME}/.kube:/${HOME}/.kube \ | |||
-v ${HOME}/.minikube:${HOME}/.minikube \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because what we really use is the ~/.kube/config configured context, not minikube (anymore)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.