Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps #3213

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Update deps #3213

merged 2 commits into from
Oct 11, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Oct 9, 2018

What this PR does / why we need it:

Update client-go to v9.0

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 9, 2018
@aledbf
Copy link
Member Author

aledbf commented Oct 9, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2018
ElvinEfendi
ElvinEfendi reviewed Oct 10, 2018
View reviewed changes
internal/ingress/status/status.go Outdated
@@ -179,19 +180,22 @@ func NewStatusSyncer(config Config) Sync {
electionID = fmt.Sprintf("%v-%v", config.ElectionID, config.IngressClass)
}

stopCh := make(chan struct{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to initialize this variable here? Just declaring would be enough, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 11, 2018
@ElvinEfendi
Copy link
Member

[k8s.io/apimachinery] Renamed KubeConfigFile to Kubeconfig in ClientConnectionConfiguration. (#67149)

this is not impacting ingress-nginx because we use clientcmd.BuildConfigFromFlags?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 38922aa into kubernetes:master Oct 11, 2018
@aledbf
Copy link
Member Author

aledbf commented Oct 11, 2018

this is not impacting ingress-nginx because we use clientcmd.BuildConfigFromFlags?

Correct

@aledbf aledbf deleted the update-deps branch October 12, 2018 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

@apelisse apelisse Awaiting requested review from apelisse

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@ElvinEfendi ElvinEfendi

@antoineco antoineco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aledbf @ElvinEfendi @k8s-ci-robot @antoineco