Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e Tests for AuthTLS #3195

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Conversation

diazjf
Copy link

@diazjf diazjf commented Oct 6, 2018

Adds E2E tests for the following annotations:

  • auth-tls-secret
  • auth-tls-verify-depth
  • auth-tls-verify-client
  • auth-tls-error-page
  • auth-tls-pass-certificate-to-upstream

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 6, 2018
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 6, 2018
@diazjf
Copy link
Author

diazjf commented Oct 6, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 6, 2018
@aledbf
Copy link
Member

aledbf commented Oct 7, 2018

@diazjf please rebase to pass CI

@diazjf diazjf force-pushed the auth-tls-e2e branch 8 times, most recently from 25b671d to 59146a4 Compare October 9, 2018 03:13
@diazjf diazjf force-pushed the auth-tls-e2e branch 14 times, most recently from b113f85 to 6fdaddb Compare October 17, 2018 19:18
@diazjf diazjf force-pushed the auth-tls-e2e branch 9 times, most recently from 70d62f5 to 7545c91 Compare October 19, 2018 00:22
@diazjf
Copy link
Author

diazjf commented Oct 19, 2018

/hold remove

@diazjf
Copy link
Author

diazjf commented Oct 19, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2018
@diazjf
Copy link
Author

diazjf commented Oct 19, 2018

Will rebase when gate is fixed.

Adds E2E tests for the following annotations:

- auth-tls-secret
- auth-tls-verify-depth
- auth-tls-verify-client
- auth-tls-error-page
- auth-tls-pass-certificate-to-upstream
@diazjf
Copy link
Author

diazjf commented Oct 19, 2018

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented Oct 19, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2018
@aledbf
Copy link
Member

aledbf commented Oct 19, 2018

@diazjf thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, diazjf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit ad89a93 into kubernetes:master Oct 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants