-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove payload from post log #3135
Conversation
internal/ingress/controller/nginx.go
Outdated
buf, err := json.Marshal(data) | ||
if err != nil { | ||
return err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you deleting this? It's actually the payload being posted below at line 833.
9af81f0
to
e9c1da9
Compare
/lgtm |
/hold |
waiting lgtm from @ElvinEfendi |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi, zrdaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This function will log sensitive public and private certificate data when called from
configureCertificates
:ingress-nginx/internal/ingress/controller/nginx.go
Lines 813 to 823 in 3f6314a
Omitting the payload will prevent sensitive data from being leaked.
@ElvinEfendi