Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the port range was too large #3108

Closed
wants to merge 1 commit into from
Closed

Conversation

hchenxa
Copy link
Contributor

@hchenxa hchenxa commented Sep 19, 2018

What this PR does / why we need it:

the port range was too large which impact the kubelet data proxying like below:

Sep 19 03:39:00 hchenxa-1 hyperkube[12683]: E0919 03:39:00.856058   12683 upgradeaware.go:310] Error proxying data from client to backend: readfrom tcp 127.0.0.1:61590->127.0.0.1:1511: write tcp 127.0.0.1:61590->127.0.0.1:1511: write: broken pipe

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

/assign @aledbf

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hchenxa
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bowei

If they are not already assigned, you can assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 19, 2018
@antoineco
Copy link
Contributor

antoineco commented Sep 20, 2018

The example aims at showing how to increase the range, for heavily loaded servers, not for local dev setups.

32768 is the default, reverting to the default has little value in my opinion.

Is there something I may have missed?

@hchenxa
Copy link
Contributor Author

hchenxa commented Sep 20, 2018

kubelet seems will use some port during startup, I apply the changes in my test environment and found some errors like below:

Sep 19 03:39:00 hchenxa-1 hyperkube[12683]: E0919 03:39:00.856058   12683 upgradeaware.go:310] Error proxying data from client to backend: readfrom tcp 127.0.0.1:61590->127.0.0.1:1511: write tcp 127.0.0.1:61590->127.0.0.1:1511: write: broken pipe

@antoineco
Copy link
Contributor

Thanks for the clarification.

@aledbf
Copy link
Member

aledbf commented Sep 20, 2018

@hchenxa as @antoineco said this example shows how to adjust the limits for heavy loaded servers
Using the defaults adds no value. That said, the issue you see is not related to this change.
Also, all the examples are just that, examples, you need to make the necessary changes for your environment
Closing.

@aledbf aledbf closed this Sep 20, 2018
@hchenxa hchenxa deleted the hchenxa_port branch October 8, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants