Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<WIP>add expire time annotation #3081

Closed
wants to merge 1 commit into from

Conversation

hchenxa
Copy link
Contributor

@hchenxa hchenxa commented Sep 12, 2018

What this PR does / why we need it:

support more annotation for session sticky like cookie expire time.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
/assign @ElvinEfendi

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hchenxa
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: elvinefendi

If they are not already assigned, you can assign the PR to them by writing /assign @elvinefendi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2018
@hchenxa hchenxa force-pushed the hchenxa_sessionsticky branch 4 times, most recently from 66bb22f to 55c95e2 Compare September 14, 2018 01:41
@hchenxa hchenxa changed the title <WIP>add expire and max age annotation add expire and max age annotation Sep 14, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2018
@aledbf
Copy link
Member

aledbf commented Sep 15, 2018

@hchenxa please add e2e tests

@hchenxa hchenxa changed the title add expire and max age annotation <WIP>add expire and max age annotation Sep 17, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2018
@hchenxa hchenxa force-pushed the hchenxa_sessionsticky branch from 55c95e2 to 8c63b67 Compare September 18, 2018 07:11
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2018
@hchenxa hchenxa force-pushed the hchenxa_sessionsticky branch from 8c63b67 to a39b79e Compare September 18, 2018 07:16
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2018
@hchenxa hchenxa changed the title <WIP>add expire and max age annotation <WIP>add expire time annotation Sep 18, 2018
@hchenxa hchenxa force-pushed the hchenxa_sessionsticky branch 4 times, most recently from 438d5c7 to a5c8794 Compare September 18, 2018 08:12
@hchenxa hchenxa force-pushed the hchenxa_sessionsticky branch from a5c8794 to fbf90a9 Compare September 18, 2018 13:45
@hchenxa hchenxa closed this Oct 29, 2018
@hchenxa hchenxa deleted the hchenxa_sessionsticky branch April 28, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants