Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete documentation about SSL Passthrough #3068

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Complete documentation about SSL Passthrough #3068

merged 1 commit into from
Sep 10, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Sep 10, 2018

What this PR does / why we need it: adds technical details about the way ingress-nginx handles SSL Passthrough.

Which issue this PR fixes: none (to my knowledge)

Special notes for your reviewer: @aledbf please make sure I didn't write nonsense 😄

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 10, 2018
@antoineco
Copy link
Contributor Author

Live pages:

@aledbf
Copy link
Member

aledbf commented Sep 10, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 10, 2018
@antoineco
Copy link
Contributor Author

Sorry, fixed a dead link real quick. It's ready now.

@aledbf
Copy link
Member

aledbf commented Sep 10, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 68a12e2 into kubernetes:master Sep 10, 2018
@antoineco antoineco deleted the docs/passthrough branch September 11, 2018 12:15
@muvaf
Copy link

muvaf commented Dec 23, 2020

Is there something I can look up to understand why SSL-passthrough incurs a performance penalty? And does it affect all requests for all Ingresses once enabled with the flag or only the ones that have this feature enabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants