-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass Host header for custom errors #3062
Pass Host header for custom errors #3062
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/check-cla |
/assign @ElvinEfendi |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, lahsivjar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks @lahsivjar ! |
What this PR does / why we need it: With
custom-http-errors
enabled the current nginx.tmpl willproxy_pass
tohttp://upstream_balancer
which will result in nginx rewriting theHost
header with a valueupstream_balancer
in which_
is an invalid character as per [RFC952]: https://www.rfc-editor.org/rfc/rfc952.txtWhich issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #3018Special notes for your reviewer: Another way to fix it can be by not using an upstream name containing any invalid characters, however, I selected this approach since the Host header might be an useful information for the custom error backend.