Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about running Ingress NGINX on bare-metal #3027

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Add documentation about running Ingress NGINX on bare-metal #3027

merged 1 commit into from
Sep 4, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Sep 2, 2018

What this PR does / why we need it: Because some users seem to struggle big time with these notions (cf. #ingress-nginx Slack channel).

Which issue this PR fixes: closes #3020

Special notes for your reviewer: Diagrams are missing (drawing in progress), but the content should already be ready-for-review.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2018
@antoineco
Copy link
Contributor Author

/assign aledbf
/assign ElvinEfendi

@aledbf
Copy link
Member

aledbf commented Sep 3, 2018

@antoineco thank you for doing this

@aledbf
Copy link
Member

aledbf commented Sep 3, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2018
@kfox1111
Copy link

kfox1111 commented Sep 4, 2018

Two other options:

  1. externalIP's on the service
  2. use metallb (https://metallb.universe.tf/)

I've used both.

@antoineco
Copy link
Contributor Author

@kfox1111 definitely something I want to cover 👍
Maybe in a second iteration.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@antoineco antoineco changed the title [WIP] Add documentation about running Ingress NGINX on bare-metal Add documentation about running Ingress NGINX on bare-metal Sep 4, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 4, 2018
@antoineco
Copy link
Contributor Author

antoineco commented Sep 4, 2018

Diagrams uploaded. See live preview.

@aledbf
Copy link
Member

aledbf commented Sep 4, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bbf4e11 into kubernetes:master Sep 4, 2018
@antoineco antoineco deleted the baremetal-docs branch September 6, 2018 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation about running Ingress NGINX on bare-metal
5 participants