Add e2e tests for CORS #3017
Merged
Add e2e tests for CORS #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold |
k8s-ci-robot
added
do-not-merge/hold
diazjf
force-pushed
the
more-e2e-1
branch
3 times, most recently
from
673c678 to
6106735
Compare
|
While I'm at it, I'll try and update the documentation. |
Codecov Report
@@ Coverage Diff @@
## master #3017 +/- ##
==========================================
+ Coverage 47.5% 47.67% +0.17%
==========================================
Files 77 77
Lines 5644 5644
==========================================
+ Hits 2681 2691 +10
+ Misses 2609 2604 -5
+ Partials 354 349 -5
Continue to review full report at Codecov.
|
Adds the missing e2e tests for Cross-Origin Resource Sharing(CORS). This will include all the CORS annotations. Also adds more unit tests.
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@diazjf thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, diazjf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the missing e2e test for Cross-Origin Resource Sharing(CORS). This will include all the CORS annotations.