Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gdb issue and update e2e image #3005

Merged
merged 1 commit into from
Aug 29, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 29, 2018

Fixes #3002 (comment) and updates the troubleshooting guide

The reason why the gdb package is not available is that during the cleanup we were removing the libpython3.6-stdlib package (required dependency)

@ElvinEfendi thank you for pointing this issue

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 29, 2018
@ElvinEfendi
Copy link
Member

/lgtm

thanks for quick fix!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-io
Copy link

Codecov Report

Merging #3005 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3005      +/-   ##
==========================================
+ Coverage   47.52%   47.54%   +0.01%     
==========================================
  Files          77       77              
  Lines        5639     5639              
==========================================
+ Hits         2680     2681       +1     
+ Misses       2607     2605       -2     
- Partials      352      353       +1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4019357...fdc9ab2. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 355b793 into kubernetes:master Aug 29, 2018
@aledbf aledbf deleted the fix-gdb branch August 29, 2018 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants