-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
now actually using the $controller and $namespace variables #2941
Conversation
before that, the panels weren't "filtered" by the controller selected with that change, each panel is, and it works for both a controller or when selecting `All`
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Codecov Report
@@ Coverage Diff @@
## master #2941 +/- ##
==========================================
+ Coverage 47.55% 47.57% +0.01%
==========================================
Files 77 77
Lines 5532 5532
==========================================
+ Hits 2631 2632 +1
+ Misses 2562 2560 -2
- Partials 339 340 +1
Continue to review full report at Codecov.
|
@clorichel please sign the CLA |
@aledbf I did try that to sign it, but hellosign link displays a 404 (and nothing with a "request new link"), so I tried to contact CNCF through https://identity.linuxfoundation.org/projects/cncf but it looks like you can't send a message from here 🙃 Do you know who can help on that for me to get a valid link and sign this thing? |
/check-cla |
@clorichel only by email |
thanks @aledbf, just sent an email out there, used the opportunity to adjust the $namespace variable too 👌 |
/check-cla |
/lgtm |
@clorichel thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, clorichel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The panels weren't "filtered" by the controller variable selected. With that change, each panel is filtered, and it works for both a specific controller or when selecting
All
.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): maybe one, maybe noneSpecial notes for your reviewer: thank you