Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

now actually using the $controller and $namespace variables #2941

Merged
merged 3 commits into from
Aug 17, 2018
Merged

now actually using the $controller and $namespace variables #2941

merged 3 commits into from
Aug 17, 2018

Conversation

clorichel
Copy link
Contributor

What this PR does / why we need it:

The panels weren't "filtered" by the controller variable selected. With that change, each panel is filtered, and it works for both a specific controller or when selecting All.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): maybe one, maybe none

Special notes for your reviewer: thank you

before that, the panels weren't "filtered" by the controller selected

with that change, each panel is, and it works for both a controller or when selecting `All`
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 14, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 14, 2018
@codecov-io
Copy link

codecov-io commented Aug 15, 2018

Codecov Report

Merging #2941 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2941      +/-   ##
==========================================
+ Coverage   47.55%   47.57%   +0.01%     
==========================================
  Files          77       77              
  Lines        5532     5532              
==========================================
+ Hits         2631     2632       +1     
+ Misses       2562     2560       -2     
- Partials      339      340       +1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ed290...6a1bbe9. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Aug 15, 2018

@clorichel please sign the CLA

@clorichel
Copy link
Contributor Author

@aledbf I did try that to sign it, but hellosign link displays a 404 (and nothing with a "request new link"), so I tried to contact CNCF through https://identity.linuxfoundation.org/projects/cncf but it looks like you can't send a message from here 🙃

Do you know who can help on that for me to get a valid link and sign this thing?

@aledbf aledbf closed this Aug 15, 2018
@aledbf aledbf reopened this Aug 15, 2018
@aledbf
Copy link
Member

aledbf commented Aug 15, 2018

/check-cla

@aledbf
Copy link
Member

aledbf commented Aug 15, 2018

@clorichel only by email [email protected]

@aledbf aledbf self-assigned this Aug 15, 2018
@clorichel clorichel changed the title now actually using the $controller variable now actually using the $controller and $namespace variables Aug 15, 2018
@clorichel
Copy link
Contributor Author

thanks @aledbf, just sent an email out there, used the opportunity to adjust the $namespace variable too 👌

@clorichel
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 17, 2018
@aledbf
Copy link
Member

aledbf commented Aug 17, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2018
@aledbf
Copy link
Member

aledbf commented Aug 17, 2018

@clorichel thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, clorichel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2018
@k8s-ci-robot k8s-ci-robot merged commit b8feded into kubernetes:master Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants