-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Lua endpoint to support dynamic certificate serving functionality #2889
Conversation
e385337
to
aca72cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #2889 +/- ##
==========================================
- Coverage 47.65% 47.57% -0.08%
==========================================
Files 76 76
Lines 5500 5484 -16
==========================================
- Hits 2621 2609 -12
+ Misses 2541 2540 -1
+ Partials 338 335 -3
Continue to review full report at Codecov.
|
@hnrytrn please squash the commits |
350eb21
to
d9ba68a
Compare
/assign ElvinEfendi |
end | ||
|
||
local err_buf = {} | ||
-- Update certificates and private keys for each host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this comment adds any value. If you think it's hard to follow the logic below then I'd suggest you extract it into a separate function with descriptive name.
d9ba68a
to
5200a38
Compare
/lgtm |
/hold |
I added hold because I don't want this to end up in 0.18.0 release. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ElvinEfendi, hnrytrn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
What this PR does / why we need it:
This PR adds a Lua endpoint to store and retrieve certificates for hosts in a shared dictionary. This is needed to support the functionality of serving SSL certificates dynamically instead of reloading NGINX.
There will be two other related PRs following this: one to post the certificates and skip the NGINX reloads on the controller side, and the other to serve the certificates stored in the shared dictionary