Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration hash calculation #2776

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 13, 2018

Test image: quay.io/aledbf/nginx-ingress-controller:0.397

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2018
@aledbf
Copy link
Member Author

aledbf commented Jul 13, 2018

@jpds this should fix the hash issue. Can you use the test image? Thanks

@jpds
Copy link

jpds commented Jul 13, 2018

All values the same now!

@codecov-io
Copy link

Codecov Report

Merging #2776 into master will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2776      +/-   ##
=========================================
- Coverage   47.64%   47.5%   -0.15%     
=========================================
  Files          74      75       +1     
  Lines        5400    5402       +2     
=========================================
- Hits         2573    2566       -7     
- Misses       2503    2511       +8     
- Partials      324     325       +1
Impacted Files Coverage Δ
internal/ingress/types.go 0% <0%> (ø)
cmd/nginx/main.go 20.39% <0%> (-4.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2cf379...9890ab3. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e1cb784 into kubernetes:master Jul 13, 2018
@aledbf aledbf deleted the hash branch July 13, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants