Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use language neutral links to MDN #2764

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Use language neutral links to MDN #2764

merged 1 commit into from
Jul 10, 2018

Conversation

tobiaswiese
Copy link
Contributor

What this PR does / why we need it: The documentation used links to the Spanish version of some MDN sites. This changes it, to use links that automatically redirect to the language the users browser sends.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 10, 2018
@tobiaswiese
Copy link
Contributor Author

/assign @nicksardo

@aledbf
Copy link
Member

aledbf commented Jul 10, 2018

@Info-Screen please don't assign PRs manually

@aledbf
Copy link
Member

aledbf commented Jul 10, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, Info-Screen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Jul 10, 2018

@Info-Screen thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2018
@codecov-io
Copy link

Codecov Report

Merging #2764 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2764      +/-   ##
==========================================
+ Coverage   40.92%   41.06%   +0.13%     
==========================================
  Files          73       73              
  Lines        5102     5102              
==========================================
+ Hits         2088     2095       +7     
+ Misses       2725     2719       -6     
+ Partials      289      288       -1
Impacted Files Coverage Δ
cmd/nginx/main.go 27.73% <0%> (+5.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 326ceec...e2f4d2c. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 0e0313c into kubernetes:master Jul 10, 2018
@tobiaswiese tobiaswiese deleted the patch-1 branch July 11, 2018 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants