-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker to build go binaries #2749
Conversation
435e84f
to
ae1eca3
Compare
114b77d
to
c4780dd
Compare
2b90035
to
0d2403d
Compare
fa37bd4
to
cd04310
Compare
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
==========================================
- Coverage 41.05% 41.03% -0.02%
==========================================
Files 73 73
Lines 5101 5101
==========================================
- Hits 2094 2093 -1
- Misses 2719 2721 +2
+ Partials 288 287 -1
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Use docker to build go binaries and runsetcap
to reduce the image size in 25MB(setcap adds metadata to the fs)