Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker to build go binaries #2749

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 6, 2018

What this PR does / why we need it:

  • Use docker to build go binaries and run setcap to reduce the image size in 25MB
    (setcap adds metadata to the fs)
  • This also removes all the dependencies required to run any makefile task from the local machine

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 6, 2018
@aledbf aledbf added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2018
@aledbf aledbf force-pushed the docker-build branch 10 times, most recently from 435e84f to ae1eca3 Compare July 6, 2018 20:11
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 6, 2018
@aledbf aledbf force-pushed the docker-build branch 4 times, most recently from 114b77d to c4780dd Compare July 6, 2018 21:42
@aledbf aledbf closed this Jul 6, 2018
@aledbf aledbf reopened this Jul 6, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 6, 2018
@aledbf aledbf force-pushed the docker-build branch 2 times, most recently from 2b90035 to 0d2403d Compare July 6, 2018 21:59
@aledbf aledbf force-pushed the docker-build branch 7 times, most recently from fa37bd4 to cd04310 Compare July 7, 2018 03:31
@codecov-io
Copy link

Codecov Report

Merging #2749 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2749      +/-   ##
==========================================
- Coverage   41.05%   41.03%   -0.02%     
==========================================
  Files          73       73              
  Lines        5101     5101              
==========================================
- Hits         2094     2093       -1     
- Misses       2719     2721       +2     
+ Partials      288      287       -1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b27693...479a519. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c9ca9ff into kubernetes:master Jul 7, 2018
@aledbf aledbf deleted the docker-build branch July 7, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants