Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx image to 0.54 #2748

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Update nginx image to 0.54 #2748

merged 1 commit into from
Jul 6, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jul 6, 2018

Test image: quay.io/aledbf/nginx-ingress-controller:0.388

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 6, 2018
@aledbf
Copy link
Member Author

aledbf commented Jul 6, 2018

@mikebryant can you test the image?

@codecov-io
Copy link

Codecov Report

Merging #2748 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2748   +/-   ##
=======================================
  Coverage   40.91%   40.91%           
=======================================
  Files          73       73           
  Lines        5101     5101           
=======================================
  Hits         2087     2087           
  Misses       2725     2725           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5827c98...61ddd0d. Read the comment docs.

@mikebryant
Copy link
Contributor

It now seems to get past the opentracing issue :)

(However now it's past that it now segfaults - I think I'm hitting #2731)

@aledbf aledbf merged commit 2b27693 into kubernetes:master Jul 6, 2018
@aledbf aledbf deleted the update-nginx branch July 7, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants