Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #2732

Merged
merged 1 commit into from
Jul 2, 2018
Merged

Improve logging #2732

merged 1 commit into from
Jul 2, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Jul 2, 2018

What this PR does / why we need it:

Improves the overall clarity of existing log messages.

Includes some minor refactoring of the store's Get...() methods to use the same func (key string) ... signature consistently.

Which issue this PR fixes:

fixes #2712
follow-up on #2639

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 2, 2018
@antoineco
Copy link
Contributor Author

/assign @aledbf
/assign @ElvinEfendi

@codecov-io
Copy link

Codecov Report

Merging #2732 into master will decrease coverage by 0.05%.
The diff coverage is 22.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2732      +/-   ##
==========================================
- Coverage   40.96%   40.91%   -0.06%     
==========================================
  Files          72       73       +1     
  Lines        5085     5101      +16     
==========================================
+ Hits         2083     2087       +4     
- Misses       2713     2725      +12     
  Partials      289      289
Impacted Files Coverage Δ
internal/ingress/controller/store/configmap.go 0% <0%> (ø) ⬆️
...nal/ingress/controller/store/ingress_annotation.go 0% <0%> (ø)
internal/ingress/controller/store/endpoint.go 0% <0%> (ø) ⬆️
internal/ingress/controller/endpoints.go 94.33% <100%> (+0.1%) ⬆️
internal/ingress/controller/store/ingress.go 71.42% <100%> (ø) ⬆️
internal/ingress/controller/store/secret.go 71.42% <100%> (ø) ⬆️
internal/ingress/controller/store/service.go 57.14% <100%> (ø) ⬆️
internal/ingress/controller/store/backend_ssl.go 44.21% <27.27%> (+0.59%) ⬆️
internal/ingress/controller/store/store.go 60.18% <33.33%> (+1.32%) ⬆️
internal/ingress/controller/controller.go 2.35% <6.25%> (-0.05%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92474ed...472dcb3. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jul 2, 2018

@antoineco I like the NotExistsError approach

@aledbf
Copy link
Member

aledbf commented Jul 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5039e77 into kubernetes:master Jul 2, 2018
aledbf added a commit to aledbf/ingress-nginx that referenced this pull request Jul 10, 2018
k8s-ci-robot added a commit that referenced this pull request Jul 10, 2018
@antoineco antoineco deleted the improve-logging branch July 20, 2018 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unexpected error generating SSL certificate
5 participants