-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging #2732
Improve logging #2732
Conversation
/assign @aledbf |
Codecov Report
@@ Coverage Diff @@
## master #2732 +/- ##
==========================================
- Coverage 40.96% 40.91% -0.06%
==========================================
Files 72 73 +1
Lines 5085 5101 +16
==========================================
+ Hits 2083 2087 +4
- Misses 2713 2725 +12
Partials 289 289
Continue to review full report at Codecov.
|
@antoineco I like the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix regression introduced in #2732
What this PR does / why we need it:
Improves the overall clarity of existing log messages.
Includes some minor refactoring of the store's
Get...()
methods to use the samefunc (key string) ...
signature consistently.Which issue this PR fixes:
fixes #2712
follow-up on #2639