Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Distributed Tracing Documentation #2697

Merged
merged 1 commit into from
Jun 24, 2018

Conversation

diazjf
Copy link

@diazjf diazjf commented Jun 24, 2018

Corrects a few items in the Zipkin Collector Example. Adds a Example of setting up the Jaeger Collector.

Corrects a few items in the Zipkin Collector Example. Adds a Example
of setting up the Jaeger Collector.
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 24, 2018
@codecov-io
Copy link

Codecov Report

Merging #2697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2697   +/-   ##
=======================================
  Coverage   40.93%   40.93%           
=======================================
  Files          72       72           
  Lines        5084     5084           
=======================================
  Hits         2081     2081           
  Misses       2715     2715           
  Partials      288      288

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd12d0...7370694. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 24, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2018
@aledbf
Copy link
Member

aledbf commented Jun 24, 2018

@diazjf thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, diazjf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2018
@k8s-ci-robot k8s-ci-robot merged commit 315679c into kubernetes:master Jun 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants