Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix in error message: encounted->encountered #2681

Merged
merged 1 commit into from
Jun 22, 2018

Conversation

AdamDang
Copy link
Contributor

Line 136: encounted->encountered

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 22, 2018
@AdamDang
Copy link
Contributor Author

/assign @bowei

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@df76d4b). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2681   +/-   ##
=========================================
  Coverage          ?   40.88%           
=========================================
  Files             ?       72           
  Lines             ?     5085           
  Branches          ?        0           
=========================================
  Hits              ?     2079           
  Misses            ?     2723           
  Partials          ?      283
Impacted Files Coverage Δ
internal/ingress/controller/template/configmap.go 77.39% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df76d4b...56b74d9. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Jun 22, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AdamDang, aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2018
@aledbf
Copy link
Member

aledbf commented Jun 22, 2018

@AdamDang thanks!

@k8s-ci-robot k8s-ci-robot merged commit 0dbc9a2 into kubernetes:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants