Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor server type to include SSLCert #2678

Merged
merged 2 commits into from
Jun 22, 2018

Conversation

hnrytrn
Copy link
Contributor

@hnrytrn hnrytrn commented Jun 21, 2018

What this PR does / why we need it:

This PR refactors the server type to include the ingress.SSLCert field. This gives us access to the certificate, which will be used to support serving SSL certificates dynamically in dynamic-configuration mode.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2018
@aledbf
Copy link
Member

aledbf commented Jun 21, 2018

@hnrytrn can you sign the CLA please?

@codecov-io
Copy link

Codecov Report

Merging #2678 into master will increase coverage by 0.07%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2678      +/-   ##
==========================================
+ Coverage   40.93%   41.01%   +0.07%     
==========================================
  Files          72       72              
  Lines        5088     5083       -5     
==========================================
+ Hits         2083     2085       +2     
+ Misses       2721     2710      -11     
- Partials      284      288       +4
Impacted Files Coverage Δ
internal/ingress/controller/metrics.go 27.27% <0%> (ø) ⬆️
internal/ingress/types_equals.go 13.17% <0%> (+0.84%) ⬆️
internal/ingress/controller/controller.go 2.25% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c78e35...86def98. Read the comment docs.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 21, 2018
@aledbf aledbf added the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jun 21, 2018
@aledbf
Copy link
Member

aledbf commented Jun 22, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2018
@aledbf
Copy link
Member

aledbf commented Jun 22, 2018

@hnrytrn thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, hnrytrn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2018
@aledbf aledbf removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jun 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 700a227 into kubernetes:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants