Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor documentation example #2624

Merged
merged 1 commit into from
Jun 11, 2018
Merged

Fix minor documentation example #2624

merged 1 commit into from
Jun 11, 2018

Conversation

pieterlange
Copy link
Contributor

os.urandom sometimes returns more bytes and its generally encouraged to use python3's secrets module for this kind of thing nowadays.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2018
@aledbf
Copy link
Member

aledbf commented Jun 11, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 11, 2018
@aledbf
Copy link
Member

aledbf commented Jun 11, 2018

@pieterlange thanks!

@pieterlange
Fix example
efdae5a 
os.urandom sometimes returns more bytes and its generally encouraged to use python3's `secrets` module.
Also double64 encode to prevent messing up the environment variables
with binary data
@pieterlange
Copy link
Contributor Author

pieterlange commented Jun 11, 2018 •
edited
Loading

Still had a minor bug when actually running it. --amended the patch, sorry

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2018
@aledbf
Copy link
Member

aledbf commented Jun 11, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, pieterlange

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 589de12 into kubernetes:master Jun 11, 2018
@codecov-io
Copy link

Codecov Report

Merging #2624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2624   +/-   ##
=======================================
  Coverage   40.88%   40.88%           
=======================================
  Files          75       75           
  Lines        5129     5129           
=======================================
  Hits         2097     2097           
  Misses       2753     2753           
  Partials      279      279

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 238ad76...efdae5a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pieterlange @aledbf @k8s-ci-robot @codecov-io