-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument controller to show configReload metrics #2542
Instrument controller to show configReload metrics #2542
Conversation
…t time it was succeeded
cd7e6b8
to
14bca24
Compare
/assign @aledbf |
@gianrubio please check the CI error |
Codecov Report
@@ Coverage Diff @@
## master #2542 +/- ##
==========================================
- Coverage 40.74% 40.69% -0.06%
==========================================
Files 73 73
Lines 5021 5033 +12
==========================================
+ Hits 2046 2048 +2
- Misses 2701 2711 +10
Partials 274 274
Continue to review full report at Codecov.
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, gianrubio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gianrubio thanks! |
This PR add prometheus metrics to detect when the controller fail to reload nginx configuration
Ex:
It also deprecate the reloadOperation metric because configReload does more than reloadOperation