Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument controller to show configReload metrics #2542

Merged
merged 2 commits into from
May 18, 2018

Conversation

gianrubio
Copy link
Contributor

This PR add prometheus metrics to detect when the controller fail to reload nginx configuration
Ex:

alert: IngressControllerFailedReload 
expr: ingress_controller_config_last_reload_successfull == 0
for: 10m

It also deprecate the reloadOperation metric because configReload does more than reloadOperation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 18, 2018
@gianrubio
Copy link
Contributor Author

/assign @aledbf

@aledbf
Copy link
Member

aledbf commented May 18, 2018

@gianrubio please check the CI error

@codecov-io
Copy link

Codecov Report

Merging #2542 into master will decrease coverage by 0.05%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
- Coverage   40.74%   40.69%   -0.06%     
==========================================
  Files          73       73              
  Lines        5021     5033      +12     
==========================================
+ Hits         2046     2048       +2     
- Misses       2701     2711      +10     
  Partials      274      274
Impacted Files Coverage Δ
internal/ingress/controller/controller.go 2.24% <0%> (-0.01%) ⬇️
internal/ingress/controller/metrics.go 27.27% <16.66%> (-6.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7640cc...67de29f. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented May 18, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, gianrubio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented May 18, 2018

@gianrubio thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit d95facd into kubernetes:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants