Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic security context to deployment YAMLs #2447

Merged
merged 1 commit into from
Apr 30, 2018

Conversation

praseodym
Copy link
Contributor

What this PR does / why we need it: Adding a security context with runAsNonRoot: false to the pod template indicates the pod's intention to run as root, and will let Kubernetes decide upon the correct pod security policy.

Which issue this PR fixes: fixes #2400

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 28, 2018
@praseodym
Copy link
Contributor Author

/assign @antoineco

@codecov-io
Copy link

Codecov Report

Merging #2447 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2447      +/-   ##
==========================================
+ Coverage   41.61%   41.67%   +0.05%     
==========================================
  Files          74       74              
  Lines        5291     5291              
==========================================
+ Hits         2202     2205       +3     
+ Misses       2792     2790       -2     
+ Partials      297      296       -1
Impacted Files Coverage Δ
cmd/nginx/main.go 23.44% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69fce01...cbb0f96. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2018
@praseodym
Copy link
Contributor Author

/assign @caseydavenport

@aledbf
Copy link
Member

aledbf commented Apr 30, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco, praseodym

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 54957aa into kubernetes:master Apr 30, 2018
@praseodym praseodym deleted the add-security-context-yaml branch April 30, 2018 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic security context to deployment YAMLs
6 participants