-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buffer configuration to external auth location config #2428
Conversation
@Eddman please run |
@aledbf Done. |
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
==========================================
+ Coverage 40.91% 41.06% +0.15%
==========================================
Files 74 74
Lines 5248 5248
==========================================
+ Hits 2147 2155 +8
+ Misses 2809 2801 -8
Partials 292 292
Continue to review full report at Codecov.
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, Eddman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Eddman thanks! |
What this PR does / why we need it:
If the External Auth service returns for instance cookies that are bigger then 4Kb the request fails.
This happens whenever external auth service returns cookies and other headers that exceed the default proxy buffer (4Kb). The configmap option
proxy-buffer-size
is completely ignored and itsproxy_buffer_size
equivalent is not propagated to the authlocation
.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):fixes #2427
Special notes for your reviewer:
no