Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment instructions for Docker for Mac (Edge) #2409

Conversation

cjlarose
Copy link
Contributor

@cjlarose cjlarose commented Apr 23, 2018

What this PR does / why we need it:

This PR adds explicit deployment instructions for ingress-nginx on Docker for Mac. It basically just reuses bits and pieces for other deployment instructions and makes getting started easier for new users coming from Docker for Mac.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2018
@codecov-io
Copy link

codecov-io commented Apr 23, 2018

Codecov Report

Merging #2409 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2409   +/-   ##
=======================================
  Coverage   40.91%   40.91%           
=======================================
  Files          74       74           
  Lines        5252     5252           
=======================================
  Hits         2149     2149           
  Misses       2809     2809           
  Partials      294      294

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9e1961...1ed2564. Read the comment docs.

@cjlarose cjlarose force-pushed the add-deploy-instructions-for-docker-for-mac branch from 74e1d14 to 7b24ab9 Compare April 23, 2018 22:08
@cjlarose cjlarose force-pushed the add-deploy-instructions-for-docker-for-mac branch from 7b24ab9 to a41ffb8 Compare April 23, 2018 22:09
@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2018
@aledbf
Copy link
Member

aledbf commented Apr 25, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco, cjlarose

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2018
@aledbf
Copy link
Member

aledbf commented Apr 25, 2018

@cjlarose thanks!

@k8s-ci-robot k8s-ci-robot merged commit 0b17e31 into kubernetes:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants