Improve speed of e2e tests

[aledbf]

Reduces the execution time in ~40%

Edit: doing this I found we need to continue improving the wait conditions and checks

https://travis-ci.org/kubernetes/ingress-nginx/jobs/368946491#L1673

[codecov-io]

Codecov Report

Merging #2383 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2383   +/-   ##
=======================================
  Coverage   39.33%   39.33%           
=======================================
  Files          73       73           
  Lines        5214     5214           
=======================================
  Hits         2051     2051           
  Misses       2874     2874           
  Partials      289      289

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fc254...42e0c0a. Read the comment docs.

[ElvinEfendi]

down to ~10m from ~16m 🎉

@aledbf can you explain briefly what change specifically causing the test performance to improve? I don't know much about ginko. Is it -nodes=2?

[aledbf]

Is it -nodes=2?

Basically, that flag indicates the number specs should run in parallel spawning go processes

[ElvinEfendi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

Checking the log we can see where we need to improve the wait filters and conditions:

[andrewloux]

@aledbf Should we add a ginkgo version || go get -u github.com/onsi/ginkgo/ginkgo to the make e2e-test task?

Writing to vendor (as dep ensure does) doesn't ensure that ginkgo is accessible as a CLI tool

[aledbf]

Should we add a ginkgo version || go get -u github.com/onsi/ginkgo/ginkgo to the make e2e-test task?

Yes. Good catch