-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync SSL certificates on events #2342
Conversation
Remove scheduled check for missing secrets.
Update secretIngressMap independently from stored annotations, which may miss some secret references.
Failing some unrelated test, rebasing on |
Codecov Report
@@ Coverage Diff @@
## master #2342 +/- ##
========================================
Coverage ? 39.1%
========================================
Files ? 73
Lines ? 5202
Branches ? 0
========================================
Hits ? 2034
Misses ? 2878
Partials ? 290
Continue to review full report at Codecov.
|
/approve |
/lgtm |
@antoineco thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
The background check for missing secrets leads to unnecessarily delayed synchronization of SSL secrets.
Illustrated scenario:
This PR improves the tracking of Ingress->Secret references using a new
ObjectRefMap
interface. At all times the map contains an up-to-date list of Secrets referenced by one or more Ingresses, including Secrets that do not exist within the cluster.All EventHandlers for Secret resources perform a lookup in the map in order to determine whether the object that triggered the event is being referenced, in which case:
The result is a more immediate feedback to changes that does not rely on arbitrary delays.