Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gRPC #2223

Merged
merged 2 commits into from
Mar 22, 2018
Merged

Add support for gRPC #2223

merged 2 commits into from
Mar 22, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 20, 2018

Which issue this PR fixes:

fixes #2207

Temporal image: quay.io/aledbf/nginx-ingress-controller:0.345
The annotation nginx.ingress.kubernetes.io/grpc-backend: "true" is required to enable this feature.
If the gRPC service requires TLS then also add the annotation
nginx.ingress.kubernetes.io/secure-backends: "true"

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2018
@aledbf aledbf added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2018
@aledbf aledbf changed the title Grpc Add support for gRPC Mar 20, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 20, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 20, 2018
@aledbf
Copy link
Member Author

aledbf commented Mar 20, 2018

Example nginx.conf

+            # In case of errors try the next upstream server before returning an error
+            proxy_next_upstream                     error timeout invalid_header http_502 http_503 http_504;
+
+            grpc_pass grpc://default-http-svc-80;
+
+            proxy_redirect                          off;
+
+        }

@aledbf
Copy link
Member Author

aledbf commented Mar 20, 2018

This is failing because the new nginx image is not published yet

@aledbf aledbf merged commit adf12fc into kubernetes:master Mar 22, 2018
@aledbf aledbf deleted the grpc branch March 22, 2018 03:51
@@ -265,6 +265,9 @@ type Location struct {
// Logs allows to enable or disable the nginx logs
// By default this is enabled
Logs log.Config `json:"logs,omitempty"`
// GRPC indicates if the kubernetes service exposes a gRPC interface
// By default this is false
GRPC bool `json:"logs,omitempty"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledbf logs part must be a typo, should not that be grpc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zaa yes. I just opened a PR to fix this

@pcj pcj mentioned this pull request Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: gRPC support
3 participants