-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for gRPC #2223
Add support for gRPC #2223
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Example nginx.conf
|
|
@@ -265,6 +265,9 @@ type Location struct { | |||
// Logs allows to enable or disable the nginx logs | |||
// By default this is enabled | |||
Logs log.Config `json:"logs,omitempty"` | |||
// GRPC indicates if the kubernetes service exposes a gRPC interface | |||
// By default this is false | |||
GRPC bool `json:"logs,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf logs
part must be a typo, should not that be grpc
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zaa yes. I just opened a PR to fix this
Which issue this PR fixes:
fixes #2207
Temporal image:
quay.io/aledbf/nginx-ingress-controller:0.345
The annotation
nginx.ingress.kubernetes.io/grpc-backend: "true"
is required to enable this feature.If the gRPC service requires TLS then also add the annotation
nginx.ingress.kubernetes.io/secure-backends: "true"