Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated BuildConfigFromFlags func #2162

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Remove duplicated BuildConfigFromFlags func #2162

merged 1 commit into from
Mar 1, 2018

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Mar 1, 2018

What this PR does / why we need it:

Use BuildConfigFromFlags from k8s.io/client-go/tools/clientcmd instead of local, identical copy.

Use BuildConfigFromFlags from k8s.io/client-go/tools/clientcmd instead
of local copy.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 1, 2018
@aledbf
Copy link
Member

aledbf commented Mar 1, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Mar 1, 2018

@antoineco thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2018
@codecov-io
Copy link

Codecov Report

Merging #2162 into master will decrease coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2162      +/-   ##
==========================================
- Coverage   36.59%   36.44%   -0.15%     
==========================================
  Files          69       69              
  Lines        4875     4862      -13     
==========================================
- Hits         1784     1772      -12     
+ Misses       2821     2820       -1     
  Partials      270      270
Impacted Files Coverage Δ
cmd/nginx/main.go 21.37% <100%> (-5.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ddb610...71eec66. Read the comment docs.

@aledbf aledbf merged commit 01399dd into kubernetes:master Mar 1, 2018
@antoineco antoineco deleted the clientcmd-buildconfigfromflags branch March 1, 2018 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants