Add publish-status-address flag #2148
Conversation
If this flag is set, status of ingress resources will be updated with this address.
|
This change is |
k8s-ci-robot
added
size/M
Codecov Report
@@ Coverage Diff @@
## master #2148 +/- ##
==========================================
+ Coverage 36.51% 36.59% +0.08%
==========================================
Files 69 69
Lines 4867 4875 +8
==========================================
+ Hits 1777 1784 +7
- Misses 2820 2821 +1
Partials 270 270
Continue to review full report at Codecov.
|
cmd/nginx/flags.go
Outdated
|
|
||
| publishStatusAddress = flags.String("publish-status-address", "", | ||
| `Address to expose the ingress controllers. The controller will set the | ||
| endpoint records on the ingress using this address.`) |
There was a problem hiding this comment.
Can you rephrase this? This could lead to understanding nginx will bind to the IP address.
There was a problem hiding this comment.
Thanks, I have updated it.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@qiujian16 thanks! |
What this PR does / why we need it:
If this flag is set, status of ingress resources will be updated
with this address.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #fix #2067
Special notes for your reviewer: