Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cors header should always be returned #2140

Merged
merged 1 commit into from
Feb 24, 2018
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 24, 2018

Which issue this PR fixes:

fixes #2138
fixes #2134

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 24, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 24, 2018
@codecov-io
Copy link

Codecov Report

Merging #2140 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2140      +/-   ##
==========================================
- Coverage   36.73%   36.59%   -0.15%     
==========================================
  Files          68       68              
  Lines        4837     4837              
==========================================
- Hits         1777     1770       -7     
- Misses       2793     2799       +6     
- Partials      267      268       +1
Impacted Files Coverage Δ
cmd/nginx/main.go 27.21% <0%> (-4.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6953ddb...23b57d4. Read the comment docs.

@aledbf aledbf merged commit 94a85c9 into kubernetes:master Feb 24, 2018
@aledbf aledbf deleted the fix-cors branch February 24, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS headers duplicated if upstream sends CORS headers CORS headers not added on 504 gateway timeout
4 participants