-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose SSL client cert data to external auth provider. #2078
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Doh. Signed the CLA with a different e-mail than was on the git commit. Signed a second CLA. |
/assign @thockin |
@rikatz ping |
Reviewing |
LGTM @aledbf This will not directly impact existing SSL Client Cert exposure, but will only expose them also when using External Authentication. I do not have any use case here (as we don't use External Auth module), but as I could see this will work fine :) |
@rikatz: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, turettn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@turettn thanks! |
@rikatz thank you for the review. |
@aledbf No problems :) pretty busy here, but when needed just mark me and I'll take a look ASAP :) |
What this PR does / why we need it: Exposing validated TLS client cert information to back-ends was added in 0.10.0. For applications that take advantage of an authorization\authentication sidecar (i.e. nginx external auth provider), it would be extremely helpful to expose this information to the sidecar as well.
Which issue this PR fixes: N/A
Special notes for your reviewer: First k8s PR. CLA signed.
Release note: