Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose SSL client cert data to external auth provider. #2078

Merged
merged 1 commit into from
Mar 19, 2018
Merged

Expose SSL client cert data to external auth provider. #2078

merged 1 commit into from
Mar 19, 2018

Conversation

turettn
Copy link

@turettn turettn commented Feb 13, 2018

What this PR does / why we need it: Exposing validated TLS client cert information to back-ends was added in 0.10.0. For applications that take advantage of an authorization\authentication sidecar (i.e. nginx external auth provider), it would be extremely helpful to expose this information to the sidecar as well.

Which issue this PR fixes: N/A

Special notes for your reviewer: First k8s PR. CLA signed.

Release note:

SSL client cert information send to back-ends is also sent to the external
auth provider, if any.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 13, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 13, 2018
@turettn
Copy link
Author

turettn commented Feb 13, 2018

Doh. Signed the CLA with a different e-mail than was on the git commit. Signed a second CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 13, 2018
@turettn
Copy link
Author

turettn commented Feb 13, 2018

/assign @thockin

@aledbf
Copy link
Member

aledbf commented Mar 18, 2018

@rikatz ping

@rikatz
Copy link
Contributor

rikatz commented Mar 19, 2018

Reviewing

@rikatz
Copy link
Contributor

rikatz commented Mar 19, 2018

LGTM

@aledbf This will not directly impact existing SSL Client Cert exposure, but will only expose them also when using External Authentication.

I do not have any use case here (as we don't use External Auth module), but as I could see this will work fine :)

@k8s-ci-robot
Copy link
Contributor

@rikatz: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

@aledbf This will not directly impact existing SSL Client Cert exposure, but will only expose them also when using External Authentication.

I do not have any use case here (as we don't use External Auth module), but as I could see this will work fine :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aledbf
Copy link
Member

aledbf commented Mar 19, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, turettn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf
Copy link
Member

aledbf commented Mar 19, 2018

@turettn thanks!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2018
@aledbf aledbf merged commit de30e53 into kubernetes:master Mar 19, 2018
@aledbf
Copy link
Member

aledbf commented Mar 19, 2018

@rikatz thank you for the review.

@rikatz
Copy link
Contributor

rikatz commented Mar 19, 2018

@aledbf No problems :) pretty busy here, but when needed just mark me and I'll take a look ASAP :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants