Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to configure the redirect code #1776

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Add option to configure the redirect code #1776

merged 1 commit into from
Nov 30, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 30, 2017

What this PR does / why we need it:

fixes #1772

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2017
@rothgar rothgar mentioned this pull request Nov 30, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 36.605% when pulling 161b485 on aledbf:redirect-setting into 120bb1d on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 36.605% when pulling 161b485 on aledbf:redirect-setting into 120bb1d on kubernetes:master.

@rothgar
Copy link
Member

rothgar commented Nov 30, 2017

LGTM. The test container worked for my application

@aledbf aledbf merged commit b39e59e into kubernetes:master Nov 30, 2017
@aledbf aledbf deleted the redirect-setting branch November 30, 2017 20:46
@tlbdk tlbdk mentioned this pull request Dec 14, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTTP method is not preserved with redirect
5 participants
@aledbf @k8s-reviewable @coveralls @rothgar @k8s-ci-robot