Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename OWNERS assignees: to approvers: #1632

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Rename OWNERS assignees: to approvers: #1632

merged 1 commit into from
Nov 1, 2017

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Oct 31, 2017 •
edited
Loading

They are effectively the same, assignees is deprecated

ref: kubernetes/test-infra#3851

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 31, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2017
@spiffxp spiffxp changed the title They are effectively the same, assignees is deprecated Rename OWNERS assignees: to approvers: Oct 31, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 33.123% when pulling 0e09105 on spiffxp:assignees-to-approvers into 41f21f8 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Nov 1, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2017
@aledbf aledbf merged commit 71da8aa into kubernetes:master Nov 1, 2017
@aledbf
Copy link
Member

aledbf commented Nov 1, 2017

@spiffxp thanks!

@spiffxp spiffxp deleted the assignees-to-approvers branch November 1, 2017 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spiffxp @k8s-reviewable @coveralls @aledbf @k8s-ci-robot