Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing unit test for nextPowerOf2 function #1554

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Add missing unit test for nextPowerOf2 function #1554

merged 1 commit into from
Oct 20, 2017

Conversation

diazjf
Copy link

@diazjf diazjf commented Oct 20, 2017

Adds a unit test for the nextPowerOf2 function in
nginx.go.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 20, 2017
Add missing unit test for nextPowerOf2 function
9878e97 
Adds a unit test for the nextPowerOf2 function in
nginx.go.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 33.555% when pulling 9878e97 on diazjf:add-power-of-2 into 99a355f on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Oct 20, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2017
@aledbf
Copy link
Member

aledbf commented Oct 20, 2017

@diazjf thanks!

@aledbf aledbf merged commit d3eef04 into kubernetes:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@diazjf @k8s-reviewable @coveralls @aledbf @k8s-ci-robot