-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the serversnippet from the config map in server blocks #1523
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
@ctriv thanks! |
For my nginx-ingress conf. I only need server-snippet for default server {} module. if you are passing only variables this makes sense. However, when a snippet with multiple lines of conditions is inserted. Having those conditions in multiple server modules is breaking stuff. And the only way content inside defaul server _( servername ;) is Server-snippet. p.s : Having server-snippet option on default and all server modules - should have a flag/optional |
…aliaes
What this PR does / why we need it:
The configmap server-snippet feature currently does not inject any directives into the server block.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: